Respect HTTP 429 and Retry-After header #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a 429 is received, sleep for the length of time indicated by Retry-After, then try again. Try up to 3 times before giving up, although the count can be configured with :ratelimit_retries if you want more or less If no Retry-After is sent by the server, defaults to 2 seconds (something is better than nothing). That should only happen with quite old and unsupported versions of GitLab
NARKOZ
approved these changes
Oct 11, 2021
|
Thank you ❤️ |
|
@NARKOZ You're welcome. I'm keen to use this addition; do you have any plans for a new version release anytime soon? |
|
I plan to release this week. |
@NARKOZ It's been a while; any chance we could get that release soon? I would be very grateful. |
|
@craigmiskell-gitlab I've just released a new version and pushed to Rubygems https://github.com/NARKOZ/gitlab/releases/tag/v4.18.0 Sorry for the wait! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a 429 is received, sleep for the length of time indicated by Retry-After, then try again.
Try up to 3 times before giving up, although the count can be configured with :ratelimit_retries if you want more or less
If no Retry-After is sent by the server, defaults to 2 seconds (something is better than nothing). That should only happen with quite old and unsupported versions of GitLab