Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace list with append in CMakeLists #671

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

marinagmoreira
Copy link
Member

No description provided.

@marinagmoreira marinagmoreira linked an issue Feb 4, 2023 that may be closed by this pull request
Copy link
Member

@bcoltin bcoltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, should have noticed this earlier! Thanks!!

@bcoltin bcoltin merged commit 539afed into nasa:develop Feb 6, 2023
marinagmoreira added a commit that referenced this pull request Mar 9, 2023
* Documentation update (#668)

* docker docs update

* make build instructions ROS1

* updating install instructions, hopefully making them easier to follow

* updated from github PR reviews

* fix typo

* replace list with append (#671)

* ci: bump to checkout@v3 (#673)

* Unlatching topics (#674)

* Changed heartbeat topic to be unlatched.

* Changed echoed command to not latching.

* no subscribers and info is obtained by service, so no latched topic needed

* removing latched on frequently published topics

* Made command topic to not atching.

* no need for these to be latched

* sub and pub in same node, no need to latch

* no need to be latched no subs and not recorded, rviz should be opened when published

* Made ground bridge topics not latched.

* Fixed heartbeat topic latched comment.

---------

Co-authored-by: Katie Browne <kathryn.browne@nasa.gov>

* support multiple versions for docs (#675)

* Make coverage_analyzer.py support Python 3 (#680)

Refactor to simplify and make output identical between Python 2 and 3

* Release 0.17.0 (#683)

* add missing glog flag that caused problems in some systems (#685)

* Make isort repeatable (#694)

* make isort repeatable

* isort now consistently groups astrobee imports as first party; one-time update to apply to old files

* moving ff_names to ff_common, updating headers (#696)

---------

Co-authored-by: Trey Smith <trey.smith@nasa.gov>
Co-authored-by: Katie Browne <kathryn.browne@nasa.gov>
luisa-mao pushed a commit to luisa-mao/astrobee-1 that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usually better practice to append rather than replace
2 participants