Merge develop into ROS2 #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docker docs update * make build instructions ROS1 * updating install instructions, hopefully making them easier to follow * updated from github PR reviews
* Changed heartbeat topic to be unlatched. * Changed echoed command to not latching. * no subscribers and info is obtained by service, so no latched topic needed * removing latched on frequently published topics * Made command topic to not atching. * no need for these to be latched * sub and pub in same node, no need to latch * no need to be latched no subs and not recorded, rviz should be opened when published * Made ground bridge topics not latched. * Fixed heartbeat topic latched comment. --------- Co-authored-by: Katie Browne <kathryn.browne@nasa.gov>
Refactor to simplify and make output identical between Python 2 and 3
* make isort repeatable * isort now consistently groups astrobee imports as first party; one-time update to apply to old files
kbrowne15
requested changes
Mar 8, 2023
| // Start heartbeat timer to ensure the system monitor gets the | ||
| // initialization fault. Doesn't matter if the node doesn't want to publish | ||
| // a heartbeat as the system monitor will unload the nodelet. | ||
| timer_heartbeat_.start(); |
There was a problem hiding this comment.
We need to make sure the timer is created. I believe you just need to remove the if statement on line 97.
kbrowne15
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some lint fixes that came from new develop rules too. They affect some .py tests, should double check if we want it or if we add an exclusion for that too