Fixes to remove traced password #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekcollison
approved these changes
Oct 12, 2018
server/client.go
Outdated
| return arg | ||
| } | ||
| m := passPat.FindAllSubmatch(arg, -1) | ||
| // Take a copy of the connect proto just for the trace message. | ||
| a := make([]byte, len(arg)) |
There was a problem hiding this comment.
Maybe place on the stack since it probably does not escape? Compiler may do this for you these days.
I used to do
var _raw [4096]byte
buf := _raw[:0]
buf = append(buf, ...)
There was a problem hiding this comment.
Thanks, updated to take this approach.
wallyqs
force-pushed
the
connect-pass-regex-fixes
branch
from
fbe9710 to
ee367ec
Compare
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
wallyqs
force-pushed
the
connect-pass-regex-fixes
branch
from
ee367ec to
a0fe8fd
Compare
|
LGTM |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to fix #762 and #766 continuing to use regex based approach to filter password entries from the log instead of using JSON.
Signed-off-by: Waldemar Quevedo wally@synadia.com
git pull --rebase origin master)Resolves #762
/cc @nats-io/core