Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computed Fields, detailed view is not rendering correctly with a long template #718

Closed
dgarros opened this issue Jul 20, 2021 · 6 comments · Fixed by #831
Closed

Computed Fields, detailed view is not rendering correctly with a long template #718

dgarros opened this issue Jul 20, 2021 · 6 comments · Fixed by #831
Assignees
Labels
type: bug Something isn't working as expected

Comments

@dgarros
Copy link
Contributor

dgarros commented Jul 20, 2021

Environment

  • Python version: 3.6
  • Nautobot version: 1.1.0b2

Steps to Reproduce

  1. Create a computed field with a long template on a single line

Expected Behavior

The detailed view for all computed field should render properly.

Observed Behavior

The detailed view for a computed field with a long template is not rendering correctly

image

@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Jul 20, 2021
@FragmentedPacket
Copy link
Contributor

This appears it may be more or less related to tables and the <pre> tag that we use in other areas as well.

I believe I have a fix for this by adding the table-layout: fixed to some CSS.

@jathanism
Copy link
Contributor

IMO we should move the template over to its own panel, like on the right side, similarly to Config Contexts/Export Templates?

Right page:
Cursor_and_Connection_Description_-_Nautobot

Full width:
Cursor_and_Connection_Description_-_Nautobot

Comparing them side-by-side, I'm partial to the latter.

@glennmatthews
Copy link
Contributor

+1 for moving them to the full-width content, though this may still be an issue with a long-enough template string, in which case I think @FragmentedPacket 's proposed CSS fix may also be necessary.

@jathanism
Copy link
Contributor

jathanism commented Jul 27, 2021

+1 for moving them to the full-width content, though this may still be an issue with a long-enough template string, in which case I think @FragmentedPacket 's proposed CSS fix may also be necessary.

If we moved to a panel, since the right-page/full-width content panels are not a table, it will overflow and present a scroll bar (see the right panel screenshot for what that looks like).

@jathanism jathanism self-assigned this Aug 13, 2021
@jathanism
Copy link
Contributor

jathanism commented Aug 13, 2021

FYI in #737 I updated the detail view template to show the Template in the right page panel (observe that the overflow allows the panel to scroll):

Right page:
Cursor_and_Connection_Description_-_Nautobot

And here's full:

Full width:
Cursor_and_Connection_Description_-_Nautobot

Let's make a final decision on which one we prefer and call this done.

@dgarros You submitted the issue, so you get to decide! 😍

@itdependsnetworks
Copy link
Contributor

My preference is right page :)

glennmatthews pushed a commit that referenced this issue Aug 20, 2021
* Fixed overflow with full width panel.

* Removed span.

* Removed style attribute and replaced with div.
glennmatthews added a commit that referenced this issue Aug 20, 2021
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 27, 2021
* next: (36 commits)
  Add release-notes for nautobot#852 and nautobot#853
  Fix nautobot#852 and nautobot#853, add regression test coverage (nautobot#854)
  Add release-notes for nautobot#493
  Add release-notes for nautobot#670 and nautobot#856
  Steps For API Key (nautobot#857)
  Doc Fix Only - update jobs docs regarding job failures (nautobot#670)
  AutoSlug with consistent API (nautobot#757)
  Add release-notes for nautobot#11 and nautobot#850
  Add documentation on how to write and preview documentation (nautobot#850)
  Added webhook suppot for plugins (nautobot#790)
  Add release-notes for nautobot#845 and nautobot#848
  Update index.md (nautobot#845)
  Update links to NAPALM (nautobot#848)
  Add release-note for nautobot#841
  Doc fixes started 8 6 21 (nautobot#841)
  Add release-notes for nautobot#652 and nautobot#830
  Don't use same db_table as previously created by health_check.db. Fixes nautobot#830 (nautobot#840)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants