Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL navbar overflowing into Graphiql remake of #781 #812

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

carbonarok
Copy link
Contributor

@carbonarok carbonarok commented Aug 13, 2021

Remake of #781

Fixes: #715

To combat this issue, the queries tab in the navigation has now been moved to the GraphiQL interface toolbar. Javascript is being used to inject the new button into the interface.

Screenshot 2021-08-12 at 14 48 40

@glennmatthews
Copy link
Contributor

Just realized that the text in nautobot/docs/models/extras/graphqlquery/#graphiql-interface needs to be updated for this change in the UI.

Also, maybe can defer to a separate PR, but the GraphQL User Guide (nautobot/docs/user-guides/graphql/) doesn't currently make any mention of the saved-queries feature, and additionally it includes a number of screenshots that predate the introduction of this feature. Would you be willing to make those updates as part of this PR as well?

@glennmatthews glennmatthews self-requested a review August 13, 2021 12:49
Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated screenshots are mostly now quite a bit larger (especially wider) than the original screenshots. Can you adjust your browser window to whatever the minimum size (width) gives an appropriately formatted view and re-take these screenshots?

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@glennmatthews glennmatthews merged commit ba8943d into nautobot:develop Aug 18, 2021
glennmatthews added a commit that referenced this pull request Aug 18, 2021
hellerve added a commit to hellerve/nautobot that referenced this pull request Aug 23, 2021
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
hellerve added a commit to hellerve/nautobot that referenced this pull request Aug 23, 2021
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved GraphQL "Queries" menu causes GraphiQL menu items to disappear in some cases
3 participants