Fix incorrect tenancy display in related prefixes table #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathanism
approved these changes
Aug 12, 2021
hellerve
added a commit
to hellerve/nautobot
that referenced
this pull request
Aug 23, 2021
* develop: (32 commits) Add object variable lookup (nautobot#837) Add release-note for nautobot#718 Fix nautobot#718: Computed field template overflow (nautobot#831) Add release-notes for nautobot#825 and nautobot#832 remove celery worker -B option (nautobot#827) Update Using Plugins guide to have Post Upgrade run. (nautobot#833) Add release-notes for nautobot#715 and nautobot#812 GraphQL navbar overflowing into Graphiql (nautobot#812) Add release-notes for nautobot#464, nautobot#731, nautobot#818 Adding Logic for read-only hdb health check (nautobot#819) Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822) Fix GraphQL filterset handling of custom fields (nautobot#821) Add release-notes for nautobot#779, nautobot#791, nautobot#809 Change the docker-compose file version to support start_period property (nautobot#810) Adding docs and logic to skip initialization in docker (nautobot#793) Fix incorrect tenancy display in related prefixes table (nautobot#806) Bump version to 1.1.3-beta.1 Bump version and add release date Add release-notes for nautobot#785 and nautobot#786 Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788) ...
hellerve
added a commit
to hellerve/nautobot
that referenced
this pull request
Aug 23, 2021
* develop: (32 commits) Add object variable lookup (nautobot#837) Add release-note for nautobot#718 Fix nautobot#718: Computed field template overflow (nautobot#831) Add release-notes for nautobot#825 and nautobot#832 remove celery worker -B option (nautobot#827) Update Using Plugins guide to have Post Upgrade run. (nautobot#833) Add release-notes for nautobot#715 and nautobot#812 GraphQL navbar overflowing into Graphiql (nautobot#812) Add release-notes for nautobot#464, nautobot#731, nautobot#818 Adding Logic for read-only hdb health check (nautobot#819) Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822) Fix GraphQL filterset handling of custom fields (nautobot#821) Add release-notes for nautobot#779, nautobot#791, nautobot#809 Change the docker-compose file version to support start_period property (nautobot#810) Adding docs and logic to skip initialization in docker (nautobot#793) Fix incorrect tenancy display in related prefixes table (nautobot#806) Bump version to 1.1.3-beta.1 Bump version and add release date Add release-notes for nautobot#785 and nautobot#786 Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #779
#779 describes a bug that we inadvertently introduced in #696 by cherry-picking several fixes from NetBox. In NetBox, the introduced bug (netbox-community/netbox#6108) was initially fixed in version 2.10.9 by removing the introduced incorrect logic (netbox-community/netbox@03b3f59), but a more complete fix was introduced by refactoring in version 2.11.x to provide a more general pattern for tenant reference columns (netbox-community/netbox@20a85c1), which was then slightly refined in netbox-community/netbox@0a1531c.
This PR therefore includes Nautobot-adapted versions of netbox-community/netbox@20a85c1 and netbox-community/netbox@0a1531c, both originally authored by @jeremystretch.
Before the fix - note that the "No Tenant" prefix in the right table incorrectly shows itself as belonging to the same tenant as the selected tenant:
After the fix - related prefix in the right table is correctly shown as having no tenant: