Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins should use Post Upgrade #832

Closed
smk4664 opened this issue Aug 19, 2021 · 4 comments · Fixed by #833
Closed

Plugins should use Post Upgrade #832

smk4664 opened this issue Aug 19, 2021 · 4 comments · Fixed by #833
Labels
type: documentation Improvements or additions to documentation

Comments

@smk4664
Copy link
Contributor

smk4664 commented Aug 19, 2021

Proposed Functionality

Plugins should use nautobot-server post_upgrade after installing plugins instead of nautobot-server migrate and nautobot-server collectstatic.

Use Case

Ease of installing plugins, and also covers bases of clearing cache, running migrations whether they think database changes have happened or not.

Database Changes

N/A

External Dependencies

N/A
@smk4664 smk4664 mentioned this issue Aug 19, 2021
Merged
@jmcgill298
Copy link
Contributor

Does this command accept an App to limit the scope of what gets executed?

@smk4664
Copy link
Contributor Author

smk4664 commented Aug 19, 2021

Not currently, it targets all. But you can turn off some of the commands.

https://nautobot.readthedocs.io/en/stable/administration/nautobot-server/#post_upgrade

@jmcgill298
Copy link
Contributor

I fear that this can cause unexpected and irreversible side effects, especially with how Poetry handles dependencies. I know that I have accidently caused Nautobot to upgrade by installing/upgrading Plugins. If it automatically ran migrations, then it would have been very difficult to rollback to the desired Nautobot version.

@smk4664
Copy link
Contributor Author

smk4664 commented Aug 20, 2021

Our existing guide just says to run nautobot-server migrate. Migrations are reversible (or should be). I will put in a PR for adding an app input to post_upgrade.

@glennmatthews glennmatthews added the type: documentation Improvements or additions to documentation label Aug 20, 2021
glennmatthews added a commit that referenced this issue Aug 20, 2021
@glennmatthews
Add release-notes for #825 and #832
44c953e
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
@hellerve
Merge branch 'develop' into 651-job-api-validation
593e0e2 
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
@hellerve
Merge branch 'develop' into 651-job-api-validation
384ccaa 
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Using Plugins guide to have Post Upgrade run. smk4664/nautobot
3 participants
@glennmatthews @jmcgill298 @smk4664