Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefixes view displays tenant name when it should not #779

Closed
evdzande opened this issue Aug 5, 2021 · 3 comments · Fixed by #806
Closed

Prefixes view displays tenant name when it should not #779

evdzande opened this issue Aug 5, 2021 · 3 comments · Fixed by #806
Assignees
@glennmatthews
Labels
type: bug Something isn't working as expected

Comments

@evdzande
Copy link
Contributor

evdzande commented Aug 5, 2021

Environment

  • Python version:
  • Nautobot version: v1.1.0

Steps to Reproduce

Everything tested on the main.demo.nautobot.com site

  1. create a prefix i.e. 192.168.0.0/16 and assign it to tenant Nautobot Airports
  2. create a prefix i.e. 192.168.0.0/16 and do not assign it to a tenant
  3. I added a description to the prefix with no tenant to determine which should not show a tenant in the Duplicate Prefixes table

Expected Behavior

Show prefix without the Tenant column filled in the Duplicate Prefixes table when opening the prefix on which a tenant is assigned.
Maybe it is better to not show the prefix at all because it is for another tenant and thus not duplicate for this tenant.

Observed Behavior

The Tenant column is filled with the Tenant name which you are viewing the prefix for but it should be empty.
image
@evdzande evdzande mentioned this issue Aug 5, 2021
Closed
@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Aug 11, 2021
@glennmatthews
Copy link
Contributor

Thank you for the report and for the detailed steps to reproduce the issue!

@glennmatthews
Copy link
Contributor

Looks like this corresponds to netbox-community/netbox#6108 - a bug that we inherited in #696.

@glennmatthews glennmatthews self-assigned this Aug 11, 2021
@glennmatthews
Copy link
Contributor

Might be worth pulling in netbox-community/netbox@20a85c1 as well.

glennmatthews added a commit that referenced this issue Aug 11, 2021
@glennmatthews
Fix #779. Port of netbox-community/netbox@20a85c1
2a717ef
@glennmatthews glennmatthews mentioned this issue Aug 11, 2021
Merged
glennmatthews added a commit that referenced this issue Aug 12, 2021
@glennmatthews
Fix incorrect tenancy display in related prefixes table (#806)
c216f5c 
* Fix #779. Port of netbox-community/netbox@20a85c1

* Port of netbox-community/netbox@0a1531c
glennmatthews added a commit that referenced this issue Aug 12, 2021
@glennmatthews
Add release-notes for #779, #791, #809
d024af1
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
@hellerve
Merge branch 'develop' into 651-job-api-validation
593e0e2 
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
@hellerve
Merge branch 'develop' into 651-job-api-validation
384ccaa 
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect tenancy display in related prefixes table nautobot/nautobot
2 participants
@glennmatthews @evdzande