Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health Check Requires Read/Write Database connection #818

Closed
nniehoff opened this issue Aug 16, 2021 · 0 comments · Fixed by #819
Closed

Health Check Requires Read/Write Database connection #818

nniehoff opened this issue Aug 16, 2021 · 0 comments · Fixed by #819
Assignees
@nniehoff
Labels
type: feature Introduction of new or enhanced functionality to the application

Comments

@nniehoff
Copy link
Contributor

Environment

  • Python version: 3.7
  • Nautobot version: 1.1.2

The built in health check script requires a Read/Write database connection. While it is probably good to check for the write capability as a valid check if Nautobot has MAINTENANCE_MODE=True it is also a valid assumption the database could be in a read-only state. In this case the health checks will fail and any service relying on this health check will incorrectly report Nautobot as down.

Steps to Reproduce

  1. Set database to Read-Only mode
  2. Start Nautobot
  3. Run healthcheck

Expected Behavior

While Nautobot continues to function with a Read-Only database it should report it's own health as healthy.

Observed Behavior

Nautobot continues to function but reports its health as bad by responding with HTTP 500.
@glennmatthews glennmatthews added type: feature Introduction of new or enhanced functionality to the application status: accepted labels Aug 16, 2021
This was referenced Aug 16, 2021
Merged
Closed
glennmatthews added a commit that referenced this issue Aug 17, 2021
@glennmatthews
Add release-notes for #464, #731, #818
a27c530
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
@hellerve
Merge branch 'develop' into 651-job-api-validation
593e0e2 
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
hellerve added a commit to hellerve/nautobot that referenced this issue Aug 23, 2021
@hellerve
Merge branch 'develop' into 651-job-api-validation
384ccaa 
* develop: (32 commits)
  Add object variable lookup (nautobot#837)
  Add release-note for nautobot#718
  Fix nautobot#718: Computed field template overflow (nautobot#831)
  Add release-notes for nautobot#825 and nautobot#832
  remove celery worker -B option (nautobot#827)
  Update Using Plugins guide to have Post Upgrade run. (nautobot#833)
  Add release-notes for nautobot#715 and nautobot#812
  GraphQL navbar overflowing into Graphiql  (nautobot#812)
  Add release-notes for nautobot#464, nautobot#731, nautobot#818
  Adding Logic for read-only hdb health check (nautobot#819)
  Fix nautobot#731 - enforce 'format' in config context schemas (nautobot#822)
  Fix GraphQL filterset handling of custom fields (nautobot#821)
  Add release-notes for nautobot#779, nautobot#791, nautobot#809
  Change the docker-compose file version to support start_period property (nautobot#810)
  Adding docs and logic to skip initialization in docker (nautobot#793)
  Fix incorrect tenancy display in related prefixes table (nautobot#806)
  Bump version to 1.1.3-beta.1
  Bump version and add release date
  Add release-notes for nautobot#785 and nautobot#786
  Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nniehoff nniehoff

Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Logic for read-only hdb health check nniehoff/nautobot
2 participants
@glennmatthews @nniehoff