Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: mapping creation and mappings tests #102

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Refactor: mapping creation and mappings tests #102

wants to merge 17 commits into from

Conversation

syphax-bouazzouni
Copy link

Prerequisite

Changes

  • simplify the post (creation of a new mapping) in the mappings_controller.rb, by re-using LinkedData::Mappings.create_mapping and models validations
  • update mappings tests to use the new mappings model (added two fields subject_source_id and object_source_id)

@syphax-bouazzouni
Auto stash before merge of "upstream" and "upstream/master"
926fe1e
@syphax-bouazzouni
Merge remote-tracking branch 'upstream/master' into upstream
acbf289
@syphax-bouazzouni
Merge remote-tracking branch 'upstream/master' into upstream
398a80c
@syphax-bouazzouni
auto lint mappings_controller et test_mappings
b68a8dc
@syphax-bouazzouni
move request_has_file? and ile_from_request to applicatio_helper
48816ea
@syphax-bouazzouni
add mappings json file parser as a mapping helper
8d7203d
@syphax-bouazzouni
add the '/load' post endpoint to mappings namespace
007dcc8
@syphax-bouazzouni
extract commun_created_mappings_test method
061e9a8
@syphax-bouazzouni
extract build_mappings_hash method in the test_mappings_controller
eedaa3d
@syphax-bouazzouni
use commun_created_mappings_test and build_mappings_hash
bbc40f1
@syphax-bouazzouni
add test_mappings_file_load in the test_mappings_controller.rb
5cf87e1
@syphax-bouazzouni
set OLD gem to 'pr/feature/add-rest-mapping-bulk-loader' to pass tests
0682e85
@syphax-bouazzouni
add mappings_helpers to find the creator user of a mapping
fcc10e6
@syphax-bouazzouni
use LinkedData::Mappings.create_mapping
8adfb02
@syphax-bouazzouni
update tests with the new mapping_hash structure
5f41bb5
@syphax-bouazzouni
update ontologies_linked_data brach to pass tests
34f0c7e
@syphax-bouazzouni
extract create_mapping_counts to the before_suite of mappings test
22f185e
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Dec 19, 2022
Closed
57 tasks
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Dec 28, 2022
Closed
67 tasks
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Sep 12, 2023
Open
@alexskr alexskr requested a review from mdorf September 12, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdorf mdorf Awaiting requested review from mdorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@syphax-bouazzouni