Skip to content

Fixes: require() of ES Module not supported #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fixes: require() of ES Module not supported #229

merged 2 commits into from
Jan 30, 2024

Conversation

barelyhuman
Copy link
Contributor

@barelyhuman barelyhuman commented Jan 30, 2024 •
edited
Loading

Draft Notes

If we wish to let users know that this is a ESM Package then the current solution should be just fine.

If not then the package needs to export hybrid for both CJS and ESM users.

Closes #179

@barelyhuman barelyhuman mentioned this pull request Jan 30, 2024
Closed
@barelyhuman barelyhuman marked this pull request as draft January 30, 2024 12:41
@barelyhuman
Copy link
Contributor Author

Additional Notes

Fail Cases

ESM: Fails with unable to import Authentication because of ESM's requirement to have the extension specified.
https://stackblitz.com/edit/stackblitz-starters-yqnavc?file=index.js

CJS: Fails with unable to require ESM module
https://stackblitz.com/edit/stackblitz-starters-cawetc?file=index.js

@barelyhuman barelyhuman self-assigned this Jan 30, 2024
@barelyhuman barelyhuman requested a review from simoneb January 30, 2024 14:05
@barelyhuman barelyhuman marked this pull request as ready for review January 30, 2024 14:07
simoneb
simoneb approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barelyhuman barelyhuman merged commit 6d2aaf5 into master Jan 30, 2024
@simoneb simoneb deleted the fix/179-require-of-es-mod branch January 30, 2024 14:57
@optic-release-automation optic-release-automation bot mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees

@barelyhuman barelyhuman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require() of ES Module not supported
2 participants
@barelyhuman @simoneb