Skip to content

Fixes: require() of ES Module not supported #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fixes: require() of ES Module not supported #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c706eb0
fix: hardcode extensions for esm only build
barelyhuman Jan 30, 2024
8c43dc3
docs: update readme with the ESM note
barelyhuman Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

# @nearform/playwright-firebase

> [!NOTE]
> This is an ESM only package, please make sure your usage follows the rules of ESM
> User the following [guide](https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c#pure-esm-package) to learn more

Tidy way to authenticate Playwright E2E tests on Firebase.

Install using npm:
Expand Down
2 changes: 1 addition & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type {
PlaywrightWorkerArgs,
PlaywrightWorkerOptions
} from '@playwright/test'
import { Authentication } from './plugin/Authentication'
import { Authentication } from './plugin/Authentication.js'

export type Credentials = {
auth: Authentication
Expand Down
2 changes: 1 addition & 1 deletion plugin/Authentication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { FirebaseApp, FirebaseOptions } from 'firebase/app'
import type { Auth, User } from 'firebase/auth'
import type { Page } from '@playwright/test'

import { addFirebaseScript, getToken } from './auth.setup'
import { addFirebaseScript, getToken } from './auth.setup.js'

// Since these are declared in browser modules, it's hard to understand what the types should be.
// As such we're defining what shape we're expecting.
Expand Down