-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ImageOS
format
#761
Fix ImageOS
format
#761
Conversation
The current algorithm given `ubuntu-18.04` returns `ubuntu18.04` when it should be `ubuntu18` according to actions/runner-images#345 (comment).
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 49.27% 50.61% +1.34%
==========================================
Files 23 23
Lines 2401 2594 +193
==========================================
+ Hits 1183 1313 +130
- Misses 1090 1142 +52
- Partials 128 139 +11
Continue to review full report at Codecov.
|
@bryannaegele this pull request has failed checks 🛠 |
It seems all PRs are failing on the mac os test at the same spot. There's a warning about attempting to use deprecated short shas. |
It fails at pulling Docker image. That is unfortunate thing we have to deal with since macOS runners don't have Docker pre-installed and thus GitHub doesn't have special API keys on them that have higher rate limits.
|
Ah. Gotcha. That's unfortunate. If I need to add any test coverage, I'd be happy to. I'm a complete amateur at Go and didn't see a good place to add it since the original PR didn't have any coverage for this, so I'm at a bit of a loss on how to go about it though 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be added in #750 otherwise TestGetGitHubContext
would need to be rewritten to read full yaml or you would have to deal with yaml.Node
s which is hell
Sounds like adding it to #750 after merge makes the most sense. |
The current algorithm given
ubuntu-18.04
returnsubuntu18.04
when it should beubuntu18
according to actions/runner-images#345 (comment).