Skip to content

Add more tests#750

Closed
catthehacker wants to merge 5 commits intonektos:masterfrom
catthehacker:cat/fix/coverage
Closed

Add more tests#750
catthehacker wants to merge 5 commits intonektos:masterfrom
catthehacker:cat/fix/coverage

Conversation

@catthehacker
Copy link
Copy Markdown
Member

  • add draw_test.go tests
  • add dryrun tests
  • add tests for environment func
  • remove unnecessary loop when reflecting and add default return
  • unexport fixIfStatement1 and add better description
  • minify workflows in tests and move some of them into one file

hackercat added 3 commits June 23, 2021 18:36
fix: remove unnecessary loop when reflecting
fix: unexport fixIfStatement1
fix: minify workflows in tests
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2021

Codecov Report

Merging #750 (2e7d07e) into master (0f04942) will increase coverage by 4.67%.
The diff coverage is 61.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   49.27%   53.94%   +4.67%     
==========================================
  Files          23       23              
  Lines        2401     2597     +196     
==========================================
+ Hits         1183     1401     +218     
+ Misses       1090     1057      -33     
- Partials      128      139      +11     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.84% <0.00%> (-0.09%) ⬇️
pkg/common/git.go 52.85% <30.15%> (-6.94%) ⬇️
pkg/runner/runner.go 68.96% <33.33%> (-7.51%) ⬇️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/model/workflow.go 42.77% <50.00%> (+17.06%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 74.76% <75.81%> (+5.81%) ⬆️
pkg/runner/run_context.go 80.36% <98.55%> (+3.95%) ⬆️
pkg/runner/command.go 90.58% <100.00%> (+2.35%) ⬆️
pkg/runner/expression.go 87.91% <100.00%> (+1.27%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 531ea02...2e7d07e. Read the comment docs.

@catthehacker catthehacker added the stale-exempt Exempt from stale label Jul 7, 2021
@bryannaegele bryannaegele mentioned this pull request Jul 27, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Nov 10, 2021

@catthehacker this pull request is now in conflict 😩

@mergify mergify Bot added the conflict PR has conflicts label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict PR has conflicts size/L stale-exempt Exempt from stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant