Skip to content

TS-82 Fixed transaction size methods #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Oct 29, 2019
Merged

TS-82 Fixed transaction size methods #326

merged 1 commit into from Oct 29, 2019

Conversation

fboucquez
Copy link
Contributor

Also: Renamed modificationType for modificationAction according to the open api spec

@fboucquez
TS-82 Fixed transaction size methods, improved testing.
08e01b9 
Renamed modificationType for modificationAction according to the open api spec
@fboucquez fboucquez requested a review from rg911 October 29, 2019 11:38
@coveralls
Copy link

coveralls commented Oct 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 786

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 785: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

@fboucquez fboucquez merged commit fee914a into symbol:master Oct 29, 2019
@fboucquez fboucquez deleted the TS-82-TransactionSizeFix branch October 29, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rg911 rg911 rg911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fboucquez @coveralls @rg911