TS-77 filtering listener's status message by subscribed address. #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg911
suggested changes
Oct 29, 2019
| }); | ||
| } | ||
|
|
||
| handleMessage(message: any, resolve) { |
There was a problem hiding this comment.
Doc, make it Private and @Internal
There was a problem hiding this comment.
can it be called from the unit test if it's private?
There was a problem hiding this comment.
ah. okay, you added unit tests. so just need to make it internal then I think
rg911
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rg911
I've added the filter by address to the listener's status subscription,
symbol/catapult-rest#174 fix has been merged. Remember to get the latest catapult-rest when working as the new status listener requires the latest rest.