Skip to content

Added GetNetworkName and other small fixes #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from Nov 19, 2019
Merged

Added GetNetworkName and other small fixes #354

merged 5 commits into from Nov 19, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Nov 15, 2019 •
edited
Loading

  • Added getNetworkName() in NetworkHttp which return the name and description of current network. Kept the getNetworkType() which return the current network identifier from node/info
  • Added validation in MosaicId construction for undefined id (though the undefined value should not get passed via type check by Typescript)
  • Fixed small bugs in serializeToJson (MosaicDefinitionTx)

Issue: #348, #319

@rg911 rg911 requested review from evias and fboucquez November 15, 2019 21:24
@rg911 rg911 changed the title Task/g348 mosaic constructor Added GetNetworkName and other small fixes Nov 15, 2019
@coveralls
Copy link

coveralls commented Nov 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 825

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 821: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

@rg911 rg911 requested a review from dgarcia360 November 15, 2019 21:27
fboucquez
fboucquez suggested changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@fboucquez fboucquez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are integration tests missing for the new getNetworkName? I've added integration tests in my PR.

evias
evias reviewed Nov 16, 2019
View reviewed changes
Copy link
Contributor

@evias evias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second @fboucquez on downcasts and response parameter handling

@rg911 rg911 merged commit 5c2feaa into symbol:master Nov 19, 2019
@rg911 rg911 deleted the task/g348_mosaic_constructor branch December 3, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarcia360 dgarcia360 Awaiting requested review from dgarcia360

2 more reviewers

@evias evias evias left review comments

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rg911 @coveralls @evias @fboucquez