Skip to content

Conversation

fboucquez
Copy link
Contributor

Hi @rg911

This PR fixes #367 / https://nem.atlassian.net/browse/TS-111

Have a look when you have time.

@fboucquez fboucquez requested a review from rg911 December 7, 2019 12:27
@coveralls
Copy link

coveralls commented Dec 7, 2019

Pull Request Test Coverage Report for Build 878

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 874: 0.0%
Covered Lines: 10
Relevant Lines: 10

💛 - Coveralls

@fboucquez
Copy link
Contributor Author

Hi @rg911,

I've just added some small DTO mapping improvements. toModel kind of methods that can be reused when converting rest DTOs to model objects. Have a look

@rg911 rg911 merged commit 679de2f into symbol:master Dec 7, 2019
@fboucquez fboucquez deleted the TS-111-getBlockByHeightNetworkTypeBug branch December 7, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getBlockByHeight networkType

3 participants