Task/g353 max fee #369
Merged
Task/g353 max fee #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimised: Transaction.resloveAlias with object assign Added: unit tests for Transaction.resloveAlias
Optimised: Transaction.resloveAlias with object assign Added: unit tests for Transaction.resloveAlias
…pescript-javascript into task/g353_max_fee
evias
reviewed
Dec 8, 2019
dgarcia360
approved these changes
Dec 9, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
setMaxFeefactory method in transaction to takefeeMultiplierOptimised: Transaction.resolveAlias() using object assign
Added: unit tests for Transaction.resolveAlias and Transaction.setMaxFee
Issue: #353