Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: add pull request template #3081

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Add: add pull request template #3081

merged 5 commits into from
Jan 11, 2024

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jan 10, 2024 •
edited
Loading

Closes #2960

This pr add pull request template.

shargon
shargon previously approved these changes Jan 10, 2024
View reviewed changes
@cschuchardt88
Copy link
Member

You could wrap in <!-- --> (Comments) so that way they dont get posted the notes. You can type in html for github.

@Jim8y
Copy link
Contributor Author

Jim8y commented Jan 11, 2024

You could wrap in <!-- --> (Comments) so that way they dont get posted the notes. You can type in html for github.

I dont think it matters. get posted the notes is not a big deal.

@Jim8y
Copy link
Contributor Author

Jim8y commented Jan 11, 2024

@shargon can be merged

@shargon shargon merged commit e04da14 into neo-project:master Jan 11, 2024
2 checks passed
@Jim8y Jim8y deleted the pr-template branch January 11, 2024 12:07
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 12, 2024
@Jim8y
Merge branch 'master' into fix-build
c426977 
* master:
  Made `MemoryStore` the default whithout `config.json` for `neo-cli` (neo-project#3085)
  Adding Devcontainer and link to codespace (neo-project#3075)
  Update & Consolidate nugets (neo-project#3083)
  Adding NNS to `neo-cli` (neo-project#3032)
  Add: add pull request template (neo-project#3081)
  Move to monorepo: Neo.Cryptography.BLS12_381 (neo-project#3077)
  Add: add a new verify result status code (neo-project#3076)
  Convert to Neo.Json and Neo.ConsoleService to `dotnet` standard 2.1 (neo-project#3044)
  Avoid IsExternalInit  (neo-project#3079)
  Clean usings (neo-project#3078)
  Fixed asp.net core project (neo-project#3067)
  Updated BLS12_381 (neo-project#3074)
  avoid nonsense exception messages. (neo-project#3063)
  Removed `MyGet` (neo-project#3071)
  Updated unit-test (neo-project#3073)
  add hash verification for OnImport (neo-project#3070)
  Make public ReadUserInput (neo-project#3068)
  Removed asp.net core (neo-project#3065)
  Enforce Line Endings in `.editorconfig` (neo-project#3060)

# Conflicts:
#	src/Neo.CLI/CLI/MainService.cs
@shargon shargon mentioned this pull request Feb 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Pull Request Template
3 participants
@Jim8y @cschuchardt88 @shargon