Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update & Consolidate nugets #3083

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Update & Consolidate nugets #3083

merged 5 commits into from
Jan 11, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 11, 2024

Description

Updated and consolidated nuget packages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Compiling

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon changed the title Update & Consolidate Update & Consolidate nugets Jan 11, 2024
@cschuchardt88
Copy link
Member

Just so you know. the version for microsoft nuget packages is based on the version of dotnet. So the 8.0.0 mean its dotnet 8.0. However when we convert to netstandard2.1 the API may or may not change. Keep that in mind.

@shargon
Copy link
Member Author

shargon commented Jan 11, 2024

I receive the following warning:

Severity Code Description Project File Line Suppression State Warning CS9057 The analyzer assembly 'C:\Users\Fernando\.nuget\packages\akka.analyzers\0.2.1\analyzers\dotnet\cs\Akka.Analyzers.dll' references version '4.8.0.0' of the compiler, which is newer than the currently running version '4.7.0.0'. Neo.Benchmarks C:\Users\Fernando\.nuget\packages\akka.analyzers\0.2.1\analyzers\dotnet\cs\Akka.Analyzers.dll 1 Active

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 11, 2024 •
edited
Loading

@shargon

Microsoft.CodeAnalysis is a bit too restrictive in terms of the versions of the compiler tooling that it supports. Hints Akka.Analyzers

Here's a mapping of the versions to VS versions to give an idea of where best to target:
https://learn.microsoft.com/en-us/visualstudio/extensibility/roslyn-version-support?view=vs-2022

@shargon shargon marked this pull request as ready for review January 11, 2024 08:01
@shargon
Copy link
Member Author

shargon commented Jan 11, 2024

@cschuchardt88 Thanks! I will update my VS to see if the error dissapear

@cschuchardt88
Copy link
Member

@shargon but won't on github. 4.8.0.0 is for Visual Studio 2022 version 17.8 (Preview)

@shargon
Copy link
Member Author

shargon commented Jan 11, 2024

@shargon but won't on github. 4.8.0.0 is for Visual Studio 2022 version 17.8 (Preview)

Then let's wait for update Akka.

@shargon shargon requested a review from Jim8y January 11, 2024 08:07
vncoelho
vncoelho reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the compilation was fine, perhaps because of the version I used as well.

@shargon shargon merged commit 5febc49 into master Jan 11, 2024
2 checks passed
@shargon shargon deleted the update-nugets branch January 11, 2024 18:36
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 12, 2024
@Jim8y
Merge branch 'master' into fix-build
c426977 
* master:
  Made `MemoryStore` the default whithout `config.json` for `neo-cli` (neo-project#3085)
  Adding Devcontainer and link to codespace (neo-project#3075)
  Update & Consolidate nugets (neo-project#3083)
  Adding NNS to `neo-cli` (neo-project#3032)
  Add: add pull request template (neo-project#3081)
  Move to monorepo: Neo.Cryptography.BLS12_381 (neo-project#3077)
  Add: add a new verify result status code (neo-project#3076)
  Convert to Neo.Json and Neo.ConsoleService to `dotnet` standard 2.1 (neo-project#3044)
  Avoid IsExternalInit  (neo-project#3079)
  Clean usings (neo-project#3078)
  Fixed asp.net core project (neo-project#3067)
  Updated BLS12_381 (neo-project#3074)
  avoid nonsense exception messages. (neo-project#3063)
  Removed `MyGet` (neo-project#3071)
  Updated unit-test (neo-project#3073)
  add hash verification for OnImport (neo-project#3070)
  Make public ReadUserInput (neo-project#3068)
  Removed asp.net core (neo-project#3065)
  Enforce Line Endings in `.editorconfig` (neo-project#3060)

# Conflicts:
#	src/Neo.CLI/CLI/MainService.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@Jim8y Jim8y Awaiting requested review from Jim8y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shargon @cschuchardt88 @vncoelho