Remove usage of CoordinateReferenceSystem #2417
Conversation
`CoordinateReferenceSystem` is not listed as `@PublicAPI`. This usage was found in a failing build. A pending internal PR is changing some constant names to fit with internal naming conventions. Rather than fix it to use the new (still internal) name; this change explicitly checks for the string, minimising direct use and assumptions, of internals.
There was a problem hiding this comment.
I have not looked at the details of the large Neo4j PR but this looks like a reasonable change to me.
Unfortunately we have not come around to fix dev PR builds and proper permission for this repo yet 😢 but ping me when you want to get it merged and I can do it for you. It is such a small change that I think it should be fine without a build
Yeah, it seems to be complaining about no source, and trying to use 4.3.0-drop03.0 😅
@Lojjs if you're happy with the change and unavoidable failing build, please merge when you can 😄 |
CoordinateReferenceSystemis not listed as@PublicAPI. This usage was found in an internal Neo4j failing build.A pending internal PR is changing some constant names to fit with internal naming conventions. Rather than fix it to use the new (still internal) name; this change explicitly checks for the string, minimising direct use, and assumptions, of internals.