Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CoordinateReferenceSystem naming #2422

Conversation

parnmatt
Copy link

@parnmatt parnmatt commented Jan 6, 2022

CoordinateReferenceSystem has changed it's internal naming. #2417 fixed the internal Neo4j build error; however, it was masking these additional usages. I should have double checked if there were more usages when investigating previously.

@parnmatt
Copy link
Author

parnmatt commented Jan 6, 2022

@Lojjs as name change has been merged into the internal dev branch; dev, and I presume a lot of other builds, are probably failing because of this oversight of mine.

Hopefully you'll see this otherwise trivial change, and freely merge it if you are happy with it.
Thanks.


I have grepped the repo, this should be all the usages fixed; and in these cases, I believe it does make sense to use the internal names (at least until we can figure out a better "public" way)

@MishaDemianenko MishaDemianenko merged commit f340b0d into neo4j-contrib:dev Jan 7, 2022
@parnmatt parnmatt deleted the Fix-CoordinateReferenceSystem-Naming branch January 7, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants