feat(completion): add reTriggerAfterIndent (#5009)

to control re-trigger or not after indent changes

Closes #4713

data/schema.json

@@ -1915,6 +1915,12 @@
       "description": "How should completion be triggered",
       "enum": ["always", "trigger", "none"]
     },
+    "suggest.reTriggerAfterIndent": {
+      "type": "boolean",
+      "description": "Re-Trigger completion after indent changes",
+      "scope": "language-overridable",
+      "default": true
+    },
     "suggest.completionItemKindLabels": {
       "type": "object",
       "default": {},

history.md

@@ -1,3 +1,15 @@
+# 2024-05-14
+
+- Added `suggest.reTriggerAfterIndent` to control re-trigger or not after indent changes
+
+# 2024-05-07
+
+- Allow `CocInstall` to install extension from Github in development mode
+
+# 2024-04-12
+
+- Change scope of codeLens configuration to `language-overridable`
+
 # 2024-03-26
 
 - Added new `--workspace-folder` argument for diagnostics lists

src/__tests__/completion/basic.test.ts

@@ -1464,6 +1464,30 @@ describe('completion', () => {
         return completion.option?.col
       }, 0)
     })
+
+    it('should not trigger completion after indent change with reTriggerAfterIndent = false', async () => {
+      helper.updateConfiguration('suggest.reTriggerAfterIndent', false)
+      await helper.createDocument('t')
+      let source: ISource = {
+        name: 'source1',
+        priority: 90,
+        enable: true,
+        sourceType: SourceType.Native,
+        doComplete: async () => Promise.resolve({
+          items: [{ word: 'endif' }]
+        })
+      }
+      disposables.push(sources.addSource(source))
+      await nvim.input('i')
+      await nvim.input('  endi')
+      await helper.waitPopup()
+      await nvim.input('f')
+      await helper.wait(10)
+      await nvim.call('setline', ['.', 'endif'])
+      await helper.wait(10)
+      let visible = await pumvisible()
+      expect(visible).toBe(false)
+    })
   })
 
   describe('sortItems', () => {

src/completion/index.ts

@@ -183,6 +183,7 @@ export class Completion implements Disposable {
       floatConfig: toObject(suggest.floatConfig),
       pumFloatConfig: suggest.pumFloatConfig,
       labelMaxLength: suggest.labelMaxLength,
+      reTriggerAfterIndent: !!suggest.reTriggerAfterIndent,
       reversePumAboveCursor: !!suggest.reversePumAboveCursor,
       snippetIndicator: toText(suggest.snippetIndicator),
       noselect: !!suggest.noselect,
@@ -264,7 +265,7 @@ export class Completion implements Disposable {
         }
       }
       // retrigger after indent
-      if (info.pre.match(/^\s*/)[0] !== option.line.match(/^\s*/)[0]) {
+      if (this.staticConfig.reTriggerAfterIndent && info.pre.match(/^\s*/)[0] !== option.line.match(/^\s*/)[0]) {
         await this.triggerCompletion(doc, info)
         return
       }

src/completion/pum.ts

@@ -67,6 +67,7 @@ export interface PopupMenuConfig {
   virtualText: boolean
   detailMaxLength: number
   detailField: string
+  reTriggerAfterIndent: boolean
   invalidInsertCharacters: string[]
 }