New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample application #95

Closed
wants to merge 2 commits into
base: master
from

Conversation

2 participants
@hglattergotz
Contributor

hglattergotz commented Nov 21, 2015

Fix minor issue in .gitignore, it is not ignoring sample/vendor.
Fix warnings in sample.php:

PHP Strict standards:  Declaration of PostSchema::getRelationships() should be compatible with Neomerx\JsonApi\Schema\SchemaProvider::getRelationships($resource, array $includeRelationships = Array) in /Users/hglattergotz/Documents/www/json-api/sample/schemas/PostSchema.php on line 52

hglattergotz added some commits Nov 21, 2015

Fix git ignore to ignore all vendor folders correctly
The /vendor/ line will not ignore the sample/vendor folder after running
composer install in the sample directory.
@neomerx

This comment has been minimized.

Owner

neomerx commented Nov 21, 2015

Can you please merge the PR into 1 commit with comment like?

Close #95

Fix sample application and .gitignore for sample app vendor folder.
@neomerx

This comment has been minimized.

Owner

neomerx commented Nov 21, 2015

And one more. Please post to 'develop'

@neomerx neomerx removed the in progress label Nov 21, 2015

@hglattergotz hglattergotz deleted the hglattergotz:fix_sample branch Nov 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment