Skip to content

Fix sample application #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix sample application #95

wants to merge 2 commits into from

Conversation

hglattergotz
Copy link
Contributor

Fix minor issue in .gitignore, it is not ignoring sample/vendor.
Fix warnings in sample.php:

PHP Strict standards:  Declaration of PostSchema::getRelationships() should be compatible with Neomerx\JsonApi\Schema\SchemaProvider::getRelationships($resource, array $includeRelationships = Array) in /Users/hglattergotz/Documents/www/json-api/sample/schemas/PostSchema.php on line 52

@hglattergotz
Fix git ignore to ignore all vendor folders correctly
3748655 
The /vendor/ line will not ignore the sample/vendor folder after running
composer install in the sample directory.
@hglattergotz
Fix method signature to match that of the base class
8f192c8
@neomerx
Copy link
Owner

neomerx commented Nov 21, 2015

Can you please merge the PR into 1 commit with comment like?

Close #95

Fix sample application and .gitignore for sample app vendor folder.

@neomerx
Copy link
Owner

neomerx commented Nov 21, 2015

And one more. Please post to 'develop'

@hglattergotz hglattergotz deleted the fix_sample branch November 21, 2015 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hglattergotz @neomerx