Skip to content

Update example to neon 0.9 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2021
Merged

Update example to neon 0.9 #77

merged 2 commits into from
Sep 13, 2021

Conversation

syohex
Copy link
Contributor

@syohex syohex commented Sep 13, 2021

EventQueue was deprecated since neon 0.9. And replace it with Channel.

@syohex
Update example to neon 0.9
6de2337 
EventQueue was deprecated since neon 0.9. And replace it with Channel.
kjvalencik
kjvalencik requested changes Sep 13, 2021
View reviewed changes
Copy link
Member

@kjvalencik kjvalencik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing these updates to the example! I have some minor suggestions. Let me know if you have any questions.

@syohex
Copy link
Contributor Author

syohex commented Sep 13, 2021

Thanks for suggestions. I have applied them.

@kjvalencik kjvalencik merged commit b603cd9 into neon-bindings:main Sep 13, 2021
@kjvalencik
Copy link
Member

Thanks @syohex!

@syohex syohex deleted the update-0.9 branch September 13, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjvalencik kjvalencik kjvalencik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syohex @kjvalencik