Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix release pipeline #9017

Merged
merged 2 commits into from
Sep 17, 2024
Merged

CI: fix release pipeline #9017

merged 2 commits into from
Sep 17, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Sep 16, 2024

Problem

We've got 2 non-blocking failures on release pipeline:

Ref https://github.com/neondatabase/neon/actions/runs/10883910015

Summary of changes

  • Always run push-to-acr-dev / push-to-acr-prod jobs, but add skip_if parameter to the reusable workflow, which can skip the job internally, without skipping it externally
  • Do not run coverage-report on release branches

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

4968 tests run: 4804 passed, 0 failed, 164 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.8% (7412 of 23294 functions)
  • lines: 49.9% (59562 of 119380 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
08a479e at 2024-09-16T19:03:18.265Z :recycle:

@bayandin bayandin merged commit cd4276f into main Sep 17, 2024
81 checks passed
@bayandin bayandin deleted the bayandin/fix-release-things branch September 17, 2024 09:17
bayandin added a commit that referenced this pull request Sep 18, 2024
## Problem

It turns out the previous approach (with `skip_if` input) doesn't work
(from #9017).
Revert it and use more straightforward if-conditions

## Summary of changes
- Revert efbe8db
- Add if-condition to`promote-compatibility-data` job and relevant
comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants