Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deploy): fix deploy to staging and prod #9030

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

bayandin
Copy link
Member

Problem

It turns out the previous approach (with skip_if input) doesn't work (from #9017).
Revert it and use more straightforward if-conditions

Summary of changes

  • Revert efbe8db
  • Add if-condition topromote-compatibility-data job and relevant comments

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Partially revert "CI(promote-compatibility-data): fix condition"
Commit efbe8db.

It turns out the previous approach (with `skip_if` input) doesn't work.
Revert it and use more straightforward if-conditions
Copy link

4968 tests run: 4804 passed, 0 failed, 164 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 31.8% (7419 of 23306 functions)
  • lines: 49.8% (59604 of 119772 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
fedf24a at 2024-09-18T11:26:35.615Z :recycle:

@bayandin bayandin enabled auto-merge (squash) September 18, 2024 13:25
@bayandin bayandin merged commit e161a2f into main Sep 18, 2024
83 checks passed
@bayandin bayandin deleted the bayandin/fix-release-again branch September 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants