Skip to content

Conversation

daskol
Copy link
Contributor

@daskol daskol commented Mar 20, 2019

In order to avoid situation when NeoVim API is updated but there is no support in Golang client I propose the method Nvim.Invoke(). This allow everybody to use the newest API level as soon as possible. As example pull request #36 is under review about half a year.

@daskol
Copy link
Contributor Author

daskol commented Mar 24, 2019

@zchee @garyburd @justinmk Any feedback?

@ghost
Copy link

ghost commented Mar 24, 2019

Note the comment at the top of apiimp.go. Do not edit the file because it's automatically generated.

Move the methods to nvim.go near the Call methods as the methods are very similar.

I am uncertain about the name Invoke, but I cannot think of anything better. Because the Nvim and Batch types have method names derived from the Nvim API, the name should not be something that Nvim is likely to use in the future.

@justinmk
Copy link
Member

Most Nvim clients would call this Request(). Is there a reason not to use that name?

@justinmk
Copy link
Member

LGTM. Let's wait a day for further comments (ping me if I forget).

@ghost
Copy link

ghost commented Mar 25, 2019

LGTM

@justinmk justinmk merged commit 79202f9 into neovim:master Mar 25, 2019
@daskol daskol deleted the feature/invoke branch March 25, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants