-
Notifications
You must be signed in to change notification settings - Fork 41
nvim: add AttachBuffer testcases #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2237b73
to
b498ff7
Compare
@justinmk |
They seem fine to me, but ok :) |
@justinmk |
|
||
go func() { | ||
<-done | ||
close(errc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: close error channel on above goroutine.
|
||
for err := range errc { | ||
if err != nil { | ||
t.Fatal(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: catch the error on above goroutine.
If occur error, called t.Fatal
on the main thread (Note that in Go, not thread, the main goroutine).
bd9bac9
to
704a88c
Compare
704a88c
to
e8b4f83
Compare
@justinmk Sorry, fixed a bits. |
@justinmk Travis CI is pending... always TravisCI is slow. That's why I said want to switch to CircleCI.. :( |
@justinmk CI is passed. ready to merge! |
@justinmk Also, I considing to port gen_doc of neovim core and generate godoc comment automatically. But this repo is for Go, I will make some changes different to between the C and Go languages spec. |
Good idea. But, I don't think porting it is good. nvim.net did something similar. But that means we have a lot of code doing the same thing. I think instead Nvim should return docs in the |
@justinmk
Interesting, what arg(or whatever) enable output more details? |
It is not possible yet. But it's worth working on that rather than rewriting gen_vimdoc.py for all clients. |
Ah I see. make sense. |
Add
AttachBuffer
testcases.