Fix SetBufferVirtualText chunks arg type
#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zchee
force-pushed
the
nvim/fix-virtualtext-chunks
branch
from
f963943 to
ccfe3fb
Compare
|
@justinmk Is there a way of checks exists virtual text? such as offset, col size or etc. |
zchee
force-pushed
the
nvim/fix-virtualtext-chunks
branch
from
ccfe3fb to
1c7c559
Compare
zchee
force-pushed
the
nvim/fix-virtualtext-chunks
branch
from
1c7c559 to
8545c79
Compare
I think not yet. |
justinmk
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
SetBufferVirtualTextchunks arg type and fix godoc comment.In the
chunksarg onSetBufferVirtualText,[]interface{}type not developer friendly. AddVirtualTextChunkstruct type and changechunkstype to[]VirtualTextChunk.The example usage exists in
nvim_test.go.