Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2023

Updates the requirements on spaze/phpstan-disallowed-calls to permit the latest version.

Release notes

Sourced from spaze/phpstan-disallowed-calls's releases.

Arrays in param configs officially not supported

  • Arrays in param configs (allowParam*, allowExceptParam* etc.) not supported at the moment (#177, #165 thanks @​mad-briller)

They never were and now it's official. It means that you can't for example allow a method call when a parameter ($message in the case below) would be an array:

parameters:
    disallowedMethodCalls:
        -
            method: 'Logger::log()'
            allowParamsAnywhere:
                -
                    position: 1
                    name: 'message'
                    value: ['foo', 'bar']

This would mean that Logger::log() would be allowed only when it would be called like Logger::log(['foo', 'bar']). And allowing that is not supported at the moment, only scalar values may be used in value:. It may change in the future though.

Also some internal changes too tiny to even list here:

  • Use fully-qualified function name in tests (6bb5575ee9a9f5ed4f434c4c90206e50f2369770)
  • Function and method can also be a list, a docblock change only (240e6e7fac7f9878d720d799c790f43bfdf9d8c3)
  • Formatting multiple calls to look like {Foo,Bar,Baz}::call() is done in one place only (d598c896bcc05f77e8b270f5a249910680686e65)
Commits
  • d598c89 Format classnames and function names etc. in one place
  • 9006bb3 Arrays in param configs not supported at the moment (#177)
  • 4f9d638 Arrays in param configs not supported at the moment, throw ShouldNotHappenExc...
  • cbdf5c9 Test calling and disallowing a function when its disallowedParam is `array|...
  • cfc7737 Fixed issue where calling a function with an array was always considered disa...
  • 240e6e7 Function and method can also be a list
  • 6bb5575 Use fully-qualified function name in tests
  • d32b50d Remove instanceof *Type (#174)
  • 5af060a Require PHPStan that has the new methods
  • 3666e16 Remove instanceof *Type checks
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @xificurk.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Apr 1, 2023
@xificurk
Copy link
Contributor

xificurk commented Apr 1, 2023

@dependabot squash and merge

Updates the requirements on [spaze/phpstan-disallowed-calls](https://github.com/spaze/phpstan-disallowed-calls) to permit the latest version.
- [Release notes](https://github.com/spaze/phpstan-disallowed-calls/releases)
- [Commits](spaze/phpstan-disallowed-calls@v2.11.6...v2.12.1)

---
updated-dependencies:
- dependency-name: spaze/phpstan-disallowed-calls
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/composer/spaze/phpstan-disallowed-calls-2.12.1 branch from 515fb4c to 8524b21 Compare April 1, 2023 05:05
@xificurk
Copy link
Contributor

xificurk commented Apr 1, 2023

@dependabot squash and merge

@dependabot dependabot bot merged commit 361daee into master Apr 1, 2023
@dependabot dependabot bot deleted the dependabot/composer/spaze/phpstan-disallowed-calls-2.12.1 branch April 1, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant