Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove const qualifier so it can be built with FCC #755
Conversation
|
@ikitayama Thank you for reporting this issue. The root of the problem is a inconsistency in the C++98 standard. Probably due to an oversight, |
|
@ikitayama Thank you for your pull request. May I kindly ask you to add a comment explaining the background for this change (see my inline comment). |
| @@ -538,7 +538,7 @@ class RecordingDevice : public Device | |||
| //! Store current values in dictionary | |||
| void get( const RecordingDevice&, DictionaryDatum& ) const; | |||
| //! Set values from dictionary | |||
| void set( const RecordingDevice&, const Buffers_&, const DictionaryDatum& ); | |||
| void set( const RecordingDevice&, Buffers_&, const DictionaryDatum& ); | |||
heplesser
Jun 16, 2017
Contributor
Please add the following comment here:
/* Note: `Buffers_&` cannot be `const` because `basic_ofstream::is_open()`
is not `const` in C++98 (cf C++ Standard §27.8.1.10).
*/
Please add the following comment here:
/* Note: `Buffers_&` cannot be `const` because `basic_ofstream::is_open()`
is not `const` in C++98 (cf C++ Standard §27.8.1.10).
*/
As of today the HEAD can not be built with FCC on the frontend for K computer. Please review and pull the patch into master.