Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices on the elevations opposite side should be clickable #7150

Closed
bluikko opened this issue Sep 2, 2021 · 7 comments
Closed

Devices on the elevations opposite side should be clickable #7150

bluikko opened this issue Sep 2, 2021 · 7 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@bluikko
Copy link
Contributor

bluikko commented Sep 2, 2021

NetBox version

v3.0.1

Feature type

Change to existing functionality

Proposed functionality

Currently in the "Elevations" view the devices that are assigned to the opposite side of the current view are shown in hatched red color. This is great, but the devices aren't currently clickable / links.
I do not see any reason why they wouldn't be clickable - it would save switching between front/back if the red hatched devices were clickable.

Use case

Make the UX better and avoid unnecessary switches between front/back just to be able to click a device.

Database changes

None.

External dependencies

None.

@bluikko bluikko added the type: feature Introduction of new functionality to the application label Sep 2, 2021
@jeremystretch
Copy link
Member

IMO this can get confusing in very busy/disorganized racks. You're typically going to be looking at the front and rear faces side-by-side anyway.

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Sep 16, 2021
@bluikko
Copy link
Contributor Author

bluikko commented Sep 17, 2021

You're typically going to be looking at the front and rear faces side-by-side anyway.

This is true for the single rack view and there's no issue there I think. My OP was considering the "Elevations" that currently displays only one side.
I guess one other option could be in addition to "Front" and "Rear" buttons, there could be "Both" that displays rack fronts in the upper row and backs in the lower row; not side-by-side since all the racks are in the same row.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Nov 16, 2021
@bluikko
Copy link
Contributor Author

bluikko commented Nov 16, 2021

Not sure if I explained it well in the OP.
I meant devices at the opposite rack face that are "full depth" - the ones shown in red/with hatch in the U.
I did not mean the "not full depth" devices at the opposite rack face that are currently not drawn at all - making them visible & clickable would indeed make a mess I think.

An example/PoC of this is at bluikko@b816ab6

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Nov 18, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Jan 18, 2022
@991jo
Copy link
Contributor

991jo commented Feb 7, 2022

I hit this issue today and can take a look at it and the code already submitted by @bluikko, get it to work and submit a PR.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Feb 7, 2022
991jo added a commit to 991jo/netbox that referenced this issue Feb 9, 2022
jeremystretch added a commit that referenced this issue Feb 10, 2022
Fixes #7150: Devices on the elevations opposite side should be clickable
jeremystretch added a commit that referenced this issue Feb 10, 2022
@wwerther
Copy link

Hi!

It seems like clicking on the far end is now working only in case no image is available. When selecting the view (labels only) I'm able to click on both ends of a device. If I select (image + labels) I can only click on the front of a device.
I think it should work in both views.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

4 participants