Skip to content

feat: default branch #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 30, 2025
Merged

feat: default branch #135

merged 22 commits into from
Oct 30, 2025
+715 −382

Conversation

@mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Oct 10, 2025 •
edited
Loading

  • add support for setting default branch for diode plugin (used for diffing when not provided in the API request)
  • add /default-branch API endpoint retrieving default branch from diode setting
  • update local development to use NetBox 4.4.2
  • fix migration warnings
  • remove setting model changes from being tracked in changelog and effectively from being branch-able

@mfiedorowicz
chore: update docker dev setup to netbox 4.4.2
0a46c45 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add branch field to Setting model and update forms and views fo…
97b8ebb 
…r integration

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: remove ChangeLoggingMixin from Setting model
37a2131 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: remove created and last_updated fields from Setting model
710ecf4 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add branch_id field to Setting model and update forms for integ…
4c41e0c 
…ration

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: implement branch handling in views for improved integration
24b3c73 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
test: add unit tests for branch_id field and related properties in Se…
9fbac4c 
…tting model

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: enhance content type handling for ManyToMany and ForeignKey fiel…
30fc47e 
…ds in matcher

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: configure logging settings with dynamic log level based on envi…
758cd25 
…ronment variable

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz self-assigned this Oct 10, 2025
@mfiedorowicz
chore(gha): remove running tests on NetBox 4.2.3
82f2093 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4123 3731 90% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/tests/test_api_get_default_branch.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/api/urls.py 100% 🟢
netbox_diode_plugin/api/views.py 79% 🟢
netbox_diode_plugin/forms.py 83% 🟢
netbox_diode_plugin/models.py 98% 🟢
netbox_diode_plugin/tests/test_models.py 95% 🟢
netbox_diode_plugin/tests/test_views.py 100% 🟢
netbox_diode_plugin/views.py 61% 🟢
TOTAL 88% 🟢

updated for commit: 32a4b71 by action🐍

jajeffries
jajeffries approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@jajeffries jajeffries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfiedorowicz
revert removal of tests for NetBox 4.2.3
1b6cc04 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix tests for NetBox 4.2.3
ba15a34 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: downgrade netboxlabs-netbox-branching to version 0.5.7
7834cbd 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: ensure make recipes return proper exit code
b4e43c7 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
Merge branch 'develop' into default-branch
914cf3c
@mfiedorowicz
tidy up migrations after rebase
7e478fa 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
refactor: rename setting branch migration file to 0007_setting_branch.py
dcb95f0 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: update migration dependencies for setting branch
4594570 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: update migration dependencies in setting branch migration
8fd5604 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
refactor: clean up Setting model and update migration dependencies
4d45f4e 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add GetDefaultBranch API view and corresponding tests
487bfcb 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
chore: tidy up tests
32a4b71 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz merged commit 1204138 into develop Oct 30, 2025
7 checks passed
@mfiedorowicz mfiedorowicz deleted the default-branch branch October 30, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jajeffries jajeffries jajeffries approved these changes

@leoparente leoparente leoparente approved these changes

@ltucker ltucker Awaiting requested review from ltucker ltucker is a code owner

@MicahParks MicahParks Awaiting requested review from MicahParks MicahParks is a code owner

Assignees

@mfiedorowicz mfiedorowicz

Labels

github-actions internal python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfiedorowicz @jajeffries @leoparente