fix(docker-compose): correct empty Redis username configuration #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
mfiedorowicz
requested review from
MicahParks,
jajeffries,
leoparente and
ltucker
as code owners
jajeffries
reviewed
Nov 25, 2025
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
RangerRick
approved these changes
Nov 25, 2025
jajeffries
approved these changes
Nov 25, 2025
barryCrunch
pushed a commit
to barryCrunch/diode
that referenced
this pull request
Nov 26, 2025
…oxlabs#441) Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set correct empty Redis username by default
This pull request updates the configuration for Redis credentials in the Diode server's Docker setup. The main focus is on how the
REDIS_USERNAMEenvironment variable is handled, ensuring consistency and proper injection of its value across the Docker Compose and sample environment files.Docker Compose configuration updates:
diode-server/docker/docker-compose.yaml, theREDIS_USERNAMEenvironment variable is now set using{REDIS_USERNAME}instead of a hardcoded empty string, allowing for dynamic assignment from the environment. [1] [2]Sample environment file update:
diode-server/docker/sample.env, the default value forREDIS_USERNAMEis changed from an empty string ("") to an empty value (REDIS_USERNAME=), clarifying that the username can be left unset or provided as needed.