fix: clean up blob directories in pre-dev #5600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
reviewed
Apr 23, 2024
Contributor
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Looks good, but I think there's a promise issue.
mrstork
force-pushed
the
pre-dev-blob-cleanup
branch
from
8fa37d0 to
4ade4b0
Compare
Contributor
|
This pull request adds or modifies JavaScript ( |
mrstork
force-pushed
the
pre-dev-blob-cleanup
branch
from
28bc631 to
8dc9982
Compare
mrstork
force-pushed
the
pre-dev-blob-cleanup
branch
2 times, most recently
from
3276df8 to
e759131
Compare
Skn0tt
reviewed
Apr 24, 2024
Contributor
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Looks great! Left one tiny comment.
mrstork
force-pushed
the
pre-dev-blob-cleanup
branch
2 times, most recently
from
55d3f38 to
04eb7b1
Compare
mrstork
force-pushed
the
pre-dev-blob-cleanup
branch
from
04eb7b1 to
059419e
Compare
Skn0tt
approved these changes
Apr 24, 2024
Contributor
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Looks great! Left one tiny nit, feel free to take it or leave it.
mrstork
added a commit
that referenced
this pull request
Apr 25, 2024
This was referenced May 23, 2024
Merged
Merged
Merged
This was referenced Jun 5, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blobs directories are interfering with
ntl devinnext-runtime-minimal, specifically around theexperimentalRegionflag. These changes clear the blob directories before runningntl dev. We already do this pre-build, we would now also be doing it pre-dev.For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.