feat: emit system log on import assertions #6590
Merged
+63
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
previously approved these changes
Jul 30, 2025
Contributor
|
Curious - why |
mrstork
reviewed
Jul 30, 2025
| ) | ||
|
|
||
| if (stderr.includes('Import assertions are deprecated')) { | ||
| log.system(`Edge function uses import assertions: ${func.path}`) |
Contributor
There was a problem hiding this comment.
Any insight as to why the new test isn't detecting this message?
Member
Author
There was a problem hiding this comment.
Because Deno 1.39.0 (the lowest version we support, and used in the tests) doesn't even print the warning. 😢
mrstork
reviewed
Jul 30, 2025
| // entirely, and what we're asserting here is that we emit a system log when | ||
| // import assertions are detected on successful builds. Also, running it on | ||
| // earlier versions won't work either, since those won't even show a warning. | ||
| test.skipIf(lt(denoVersion, '1.46.3') || gte(denoVersion, '2.0.0'))( |
Contributor
There was a problem hiding this comment.
I believe the current CI setup only runs in 1.39.0 and 2.2.4, so this test will not run in CI. Are we okay with this being a local development only test?
Member
Author
There was a problem hiding this comment.
Yes. I have explained in more detail here. The only option would be to add 1.46.3 to the matrix just for this test, but feels like an overkill.
mrstork
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Emits a system log whenever we bundle an edge function that uses import assertions.