fix: only target file: specifiers when extracting ESZIP
#6722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
changed the title
file: specifiers when extracting ESZIP
eduardoboucas
commented
Oct 22, 2025
| const tail = url.pathname.split("/").filter(Boolean); | ||
| const relativePath = tail.length === 0 ? [".root"] : tail; | ||
| return join(url.hostname, ...relativePath); | ||
| function url2path(url: string) { |
Member
Author
There was a problem hiding this comment.
Reverting this to the original version.
JakeChampion
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6720. The ESZIP extraction logic that maps specifiers to paths on disk had some issues.
We can't easily map a full URL to paths on disks without breaking the hierarchy of imports, because if we see
https://example.com/fooandhttps://example.com/foo/bar.ts, we'd need to represent the/foonode as both a file and a directory.So in this PR we're changing the extraction logic to only extract local files. Any other specifiers will be left alone and will follow the normal resolution by the
deno runcall.