Skip to content

Conversation

@mrstork
Copy link
Contributor

@mrstork mrstork commented Oct 27, 2025

Summary

Updates the default edge_bundler_deno_v2 value to true
Enables us to upgrade the deno version in buildbot


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork marked this pull request as ready for review October 27, 2025 15:24
@mrstork mrstork requested a review from a team as a code owner October 27, 2025 15:24
Comment on lines 56 to +57
# Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
# We're adding v2.4.2 here because it's needed for the upcoming nimble release, so we can test
# those workflows ahead of time before we can update the base version across the board.
deno-version: ['v1.39.0', 'v2.2.4', 'v2.4.2']
deno-version: ['v2.4.2']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export const DENO_VERSION_RANGE = '1.39.0 - 2.2.4'

we still do allow deno 1 in allowed versions. The comment say we should include it? Or change the range in deno/bridge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without changing the value in CI, I get all the test failures in the first commit and requires quite a few code changes in addition to the default flag value change. Changing the flag default is effectively changing the accepted range in deno/bridge but without removing the feature flag (since we would like to keep it around until the release is in the clear). The next release of build after this one will be removing the feature flag and cleaning up all the remaining code, but to keep the change set small in case a revert is needed, this was the path selected. Open to alternatives.

@mrstork mrstork merged commit bb304c9 into main Oct 27, 2025
30 checks passed
@mrstork mrstork deleted the deno-v2-flag-default branch October 27, 2025 16:53
mrstork added a commit that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants