fix: update deno run commands to set node-modules-dir to manual #6771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/build
branch
3 times, most recently
from
aaea002 to
962297f
Compare
JakeChampion
changed the title
JakeChampion
changed the title
| (Netlify Build completed in 1ms)␊ | ||
| Build step duration: Netlify Build completed in 1ms` | ||
|
|
||
| ## In integration dev mode, install local plugins and install the integration when forcing build |
Member
There was a problem hiding this comment.
How come this is getting removed?
Contributor
Author
There was a problem hiding this comment.
This test does not exist - which is why the snapshot was removed when I regenerated snapshots
Reorders the code to add vendor import maps before bundle generation starts. This ensures the import map is properly initialized with vendor dependencies before any bundling logic executes, preventing potential issues with missing dependencies during the bundling process.
JakeChampion
force-pushed
the
jake/build
branch
2 times, most recently
from
3893be8 to
654f9fc
Compare
JakeChampion
force-pushed
the
jake/build
branch
from
654f9fc to
f7ad345
Compare
JakeChampion
changed the title
JakeChampion
commented
Nov 11, 2025
Comment on lines
+126
to
+129
| if (vendor) { | ||
| importMap.add(vendor.importMap) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this fixes a bug where we were not including npm/vendor dependencies for our tarball bundles
JakeChampion
commented
Nov 11, 2025
| '--quiet', | ||
| '--code-splitting', | ||
| '--allow-import', | ||
| '--node-modules-dir=manual', |
Contributor
Author
There was a problem hiding this comment.
This fixes the bug where Deno was adding a .deno folder into the node_modules folder, which caused issues for our hosted build system as it would cache the .deno folder - which is not a good thing to do because the package versions that Deno was selecting were not adhering to the Netlify Edge Functions' lockfiles (if those lockfiles were from bun/pnpm/yarn/npm)
eduardoboucas
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
--node-modules-dir=manualflag to deno bundle commands in tarball bundling.Docs: https://docs.deno.com/runtime/fundamentals/node/#choosing-a-node_modules-mode
This will stop our bundling step from accidentally adding a
.denofolder into thenode_modulesfolder, which was causing issues for builds which use a cachednode_modulesfolderThis was a bit difficult to test out locally, I instead did a manual test using buildbot via https://github.com/netlify/buildbot/pull/3874 and then making a site's build use this custom buildbot image