-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(command-dev): add support for functionsPort flag fixes #3980 #4048
feat(command-dev): add support for functionsPort flag fixes #3980 #4048
Conversation
@tinfoil-knight thanks for taking the time to contribute to the CLI. Can you please reference the issue here that you are solving? Just to get more background on the fix and to understand the problem |
@lukasholzer The issue number is available in the title. I've also added it now to the description above now. Issue Link: #3980 |
@lukasholzer While this issue adds a command line flag and documents it, I couldn't find the source repo for adding it to this page: docs.netlify.com/configure-builds/file-based-configuration/#netlify-dev which should ideally have the list of all supported options in |
Thx, sorry have not seen this inside the title 🤦🏻♂️ – please always fill out the template correctly as GitHub auto detects words like |
Yea this has to be documented in our private repository: https://github.com/netlify/docs but I can do this for you :) |
My bad. Will remember from next time. |
cc @KyleBlankRollins maybe you can outline the docs strategy on how we should document this. As flags are not documented on the file based configuration at all and I cannot find the |
Thanks @tinfoil-knight for the PR and @lukasholzer for the review 🚀 We should also update https://github.com/netlify/cli/blob/41e6729c7413a170d96e6a6020b7200a478976bb/docs/netlify-dev.md#netlifytoml-dev-block, which is part of the CLI repo. @lukasholzer for the docs site, we can open an issue on our private repo and link this PR and the relevant docs section (https://docs.netlify.com/configure-builds/file-based-configuration/#netlify-dev). |
@erezrokah I opened up a docs PR in our repository: https://github.com/netlify/docs/pull/1700 (private) |
Summary
netlify dev
already supports specifying thefunctionsPort
setting used to set the port for functions server innetlify.toml
.Now, the
functionsPort
can now be specified through a command line flag too like:netlify dev --functionsPort <port>
Fixes: #3980
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.