chore: converts watch and init commands to clack #6346
Conversation
lemusthelroy
changed the title
|
Only TODO left on this is to ensure the site creation path for the init route is converted to clack |
There was a problem hiding this comment.
Small grammatical things here and there but otherwise good.
One thing that I'm not sure about though is the need for exit: true to be passed in all over the place with the use of the outro method.
Is this something that we'd always want to have happen? If so, could we expose a helper method that allows a user to call outro with the message and we automatically pass in exit: true?
| @@ -29,13 +47,37 @@ import { intro, outro } from '../../utils/styles/index.js' | |||
| export const basicCommand = () => { | |||
| intro('basic command') | |||
| // do stuff | |||
| outro() | |||
| outro({ message: 'Your message', exit: true }) | |||
There was a problem hiding this comment.
If exit: true were not passed, what would happen?
There was a problem hiding this comment.
It would just print the outro message. I think the signature of this was updated recently so this just updates it to the current signature. I am intrigued as to whether exit should always just happen otherwise clack will just look weird, but will probably tackle that separately.
There was a problem hiding this comment.
Agree with your other comment on the outro bit. Will circle back to that as I agree
Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
lemusthelroy
merged commit 28ae1ed
into
CP-101/design-system-clack-implementation
lemusthelroy
deleted the
lemusthelroy/ct-487-convert-watch-command-to-clack
branch
🎉 Thanks for submitting a pull request! 🎉
Summary
Converts watch and init commands to clack. Also, adjusts styling for the outro of unlinking.
Watch, where you link to existing site:
Watch, where site already linked:
Watch, where site gets created:
Link:
Also contains guidance so we avoid having multiple intros and outros like this:
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)