-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: convert dev command to clack #6366
Merged
lemusthelroy
merged 28 commits into
CP-101/design-system-clack-implementation
from
CP-101/convert-dev-command
Mar 19, 2024
Merged
chore: convert dev command to clack #6366
lemusthelroy
merged 28 commits into
CP-101/design-system-clack-implementation
from
CP-101/convert-dev-command
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to not call outro if framework
lemusthelroy
changed the title
chore: wip convert dev command and stream logs into NetlifyLog - need…
chore: convert dev command to clack
Feb 1, 2024
khendrikse
approved these changes
Feb 1, 2024
Going to have to revisit this PR due to the snapshot tests on the framework detection tests |
I ran into issues with this branch locally when trying to switch user. Will investigate further. |
lemusthelroy
merged commit Mar 19, 2024
3f7e207
into
CP-101/design-system-clack-implementation
32 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Converts
dev
command to Clack. This is a difficult command to test as there is a lot of different routes to cover, based on what type of project thedev
command is being run on. I have tested, and include screenshots below, for the following scenarios:Static site (with edge function):
Astro site:
Next site:
For reference, this is what this command looked like previously:
What this PR does not include
dev
scenariosboxen
that present the server as being ready. We know this is a visual cue for many users so want to make sure we get this right.Other notes to reviewers
@netlify/build
that log out messages that break the clack styling which is why I have opted to transport anyconsole.log
intoNetlifyLog
. This is worth taking some time to review but I think it is necessary.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)