Add method to get all enabled feature flags for a user #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitop
added
the
type: feature
emilyzhang
previously approved these changes
Oct 1, 2020
emilyzhang
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In buildbot, we want to start passing feature flags down to netlify build. To do so, we need a method to get all enabled flags for a user. For this particular case, we only care about boolean ones.
This adds a method to the featureflag package to do so. LanuchDarkly's Go SDK provides a way to get all flags for a user, so we wrap that in another method to select just the enabled boolean ones.
For tests, it uses the file config as suggested by LaunchDarkly docs: https://docs.launchdarkly.com/sdk/concepts/flags-from-files