Skip to content

Make featureflag.MockClient return enabled flags in AllEnabledFlags #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

Make featureflag.MockClient return enabled flags in AllEnabledFlags #190

merged 1 commit into from
Oct 9, 2020

Conversation

kitop
Copy link
Contributor

@kitop kitop commented Oct 9, 2020

Followup to #187

The MockClient should respect the flags set for it.

@kitop kitop added the type: bug code to address defects in shipped code label Oct 9, 2020
@kitop kitop requested a review from a team as a code owner October 9, 2020 19:06
@kitop kitop merged commit 8f699f8 into master Oct 9, 2020
@kitop kitop deleted the mock-client-returning-enabled-flags branch October 9, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vbrown608 vbrown608 vbrown608 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitop @vbrown608