Skip to content

PhpStan fixes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2019
Merged

PhpStan fixes #16

merged 1 commit into from
Aug 11, 2019

Conversation

janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Aug 11, 2019

  • bug fix
  • BC break? yes

Snímek obrazovky 2019-08-11 v 12 08 38

Fixed PhpStan suggestions:

------ ------------------------------------------------------------------------ 
 Line   RobotLoader/RobotLoader.php                                             
------ ------------------------------------------------------------------------ 
 125    Call to function is_array() with string will always evaluate to false.  
 147    Call to function is_array() with string will always evaluate to false.  
 244    Parameter #2 $subject of function preg_split expects string, array      
        given.                                                                  
 255    Parameter #2 $subject of function preg_split expects string, array      
        given.                                                                  
 347    Variable $name might not be defined.                                    
 369    Variable $name might not be defined.                                    
 375    Variable $name might not be defined.                                    
------ ------------------------------------------------------------------------ 

@JanTvrdik
Copy link
Contributor

I'm not sure it's a good idea to document deprecated APIs.

@dg
Copy link
Member

dg commented Aug 11, 2019

Thanks. I'll merge it without documentation for deprecated API.

@dg dg merged commit 9d7dbbc into nette:master Aug 11, 2019
dg pushed a commit that referenced this pull request Aug 11, 2019
dg pushed a commit that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants