Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpStan fixes #16

Merged
merged 1 commit into from Aug 11, 2019
Merged

PhpStan fixes #16

merged 1 commit into from Aug 11, 2019

Conversation

@janbarasek
Copy link
Contributor

janbarasek commented Aug 11, 2019

  • bug fix
  • BC break? yes

Snímek obrazovky 2019-08-11 v 12 08 38

Fixed PhpStan suggestions:

------ ------------------------------------------------------------------------ 
 Line   RobotLoader/RobotLoader.php                                             
------ ------------------------------------------------------------------------ 
 125    Call to function is_array() with string will always evaluate to false.  
 147    Call to function is_array() with string will always evaluate to false.  
 244    Parameter #2 $subject of function preg_split expects string, array      
        given.                                                                  
 255    Parameter #2 $subject of function preg_split expects string, array      
        given.                                                                  
 347    Variable $name might not be defined.                                    
 369    Variable $name might not be defined.                                    
 375    Variable $name might not be defined.                                    
------ ------------------------------------------------------------------------ 
@JanTvrdik

This comment has been minimized.

Copy link
Contributor

JanTvrdik commented Aug 11, 2019

I'm not sure it's a good idea to document deprecated APIs.

@dg

This comment has been minimized.

Copy link
Member

dg commented Aug 11, 2019

Thanks. I'll merge it without documentation for deprecated API.

@dg dg merged commit 9d7dbbc into nette:master Aug 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dg added a commit that referenced this pull request Aug 11, 2019
dg added a commit that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.