removed dependency on nette/caching #7
Conversation
dg
force-pushed
the
caching
branch
2 times, most recently
from
1581a88 to
59edb76
Compare
|
Good idea, I'll review the implementation in the morning |
|
|
||
|
|
||
| /** | ||
| * @return string |
There was a problem hiding this comment.
should be @return array (or @return mixed in theory, as it may be overridden to return anything that is serializable, but i like @return array more.
| /** @deprecated */ | ||
| public function setCacheStorage(Nette\Caching\IStorage $storage) | ||
| { | ||
| trigger_error(__METHOD__ . '() is deprecated; use setTempDirectory() instead.', E_USER_DEPRECATED); |
There was a problem hiding this comment.
For FileStorage instances, we may for compatibility reasons call setTempDirectory with $storage->dir (private, so minor hacking would be required).
For other storages, exception should be thrown as RobotLoader is entirely broken and will not work unless fixed by programmer.
| * @internal | ||
| */ | ||
| public function rebuildCallback() | ||
| private function refreshCache() |
There was a problem hiding this comment.
The return value of refreshCache is never used
| return; | ||
| } | ||
| $file = $this->getCacheFile(); | ||
| $list = @include $file; |
There was a problem hiding this comment.
maybe assign directly to $this->classes?
that would allow omitting $list = $this->classes and $this->classes = $list lines
| } | ||
|
|
||
| $file = $this->getCacheFile(); | ||
| $code = '<?php return ' . var_export($this->classes, TRUE) . ';'; |
There was a problem hiding this comment.
I thought about better formatting (newlines after <?php, replacing path prefix with __DIR__, ...) but it's probably not worth it – it used to be totally unreadable serialized format, even default var_export formatting is a lot more readable.
|
Looks like updated. Could you review @JanTvrdik, please? |
| } | ||
|
|
||
|
|
||
| /** | ||
| * @return array | ||
| */ | ||
| protected function getKey() | ||
| private function getCacheFile() |
dg
force-pushed
the
caching
branch
2 times, most recently
from
fe1fde2 to
7030c2f
Compare
|
@JanTvrdik thx for review |
Cache file is ordinary PHP file.