EntityManagerFactory: event manager is always taken from connection #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uestla
force-pushed
the
patch-event-manager
branch
from
d41a287 to
ed0eeb7
Compare
Member
|
You're right. Thank you. :-) Nice job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current state, the factory checks that the optionally passed
EventManageris the very same as the one inConfiguration. Right afterwards it still uses the configurational one (var$eventManageris never used).Funny enough, thanks to this I discovered another bug in dbal (already fixed) :-)
This may be a BC break for people who overloaded
@orm.entityManagerin their configuration.