Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityManagerFactory: event manager is always taken from connection #11

Merged
merged 1 commit into from Apr 26, 2018

Conversation

2 participants
@uestla
Copy link
Contributor

uestla commented Apr 26, 2018

In current state, the factory checks that the optionally passed EventManager is the very same as the one in Configuration. Right afterwards it still uses the configurational one (var $eventManager is never used).

Funny enough, thanks to this I discovered another bug in dbal (already fixed) :-)


This may be a BC break for people who overloaded @orm.entityManager in their configuration.

@uestla uestla force-pushed the uestla:patch-event-manager branch from d41a287 to ed0eeb7 Apr 26, 2018

@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Apr 26, 2018

You're right. Thank you. :-) Nice job.

@f3l1x f3l1x merged commit 883d2fb into nettrine:master Apr 26, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.4%) to 31.818%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f3l1x f3l1x added the feature label Apr 26, 2018

@f3l1x f3l1x added this to the v0.2 milestone Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.